]> git.puffer.fish Git - mirror/frr.git/commitdiff
lib: set change errmsg in sysrepo session 15294/head
authorali-aqrabawi <aaqrabaw@okdanetworks.com>
Sat, 3 Feb 2024 20:57:13 +0000 (23:57 +0300)
committerali-aqrabawi <aaqrabaw@okdanetworks.com>
Sat, 3 Feb 2024 20:57:13 +0000 (23:57 +0300)
this will enable sysrepo based cli users to know what went wrong
when config change fails

Signed-off-by: ali-aqrabawi <aaqrabaw@okdanetworks.com>
lib/northbound_sysrepo.c

index 198d96e3811cd98e3ad9cc8425bda11b8c66d01f..4942d66850ec2d74305dbfd9acb0530e53883caf 100644 (file)
@@ -279,11 +279,12 @@ static int frr_sr_config_change_cb_prepare(sr_session_ctx_t *session,
        ret = nb_candidate_commit_prepare(context, candidate, NULL,
                                          &transaction, false, false, errmsg,
                                          sizeof(errmsg));
-       if (ret != NB_OK && ret != NB_ERR_NO_CHANGES)
-               flog_warn(
-                       EC_LIB_LIBSYSREPO,
-                       "%s: failed to prepare configuration transaction: %s (%s)",
-                       __func__, nb_err_name(ret), errmsg);
+       if (ret != NB_OK && ret != NB_ERR_NO_CHANGES) {
+               flog_warn(EC_LIB_LIBSYSREPO,
+                         "%s: failed to prepare configuration transaction: %s (%s)",
+                         __func__, nb_err_name(ret), errmsg);
+               sr_session_set_error_message(session, errmsg);
+       }
 
        if (!transaction)
                nb_config_free(candidate);