]> git.puffer.fish Git - mirror/frr.git/commitdiff
lib: Fix possible usage of uninited data
authorDonald Sharp <sharpd@nvidia.com>
Thu, 17 Feb 2022 19:07:57 +0000 (14:07 -0500)
committermergify-bot <noreply@mergify.com>
Wed, 23 Feb 2022 17:34:57 +0000 (17:34 +0000)
assert when if_lookup_address is passed with
a family that is not AF_INET or AF_INET6 as
that we are dead in the water and this is a
dev escape

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
(cherry picked from commit 4d7aae38ab5f88421dea48a6f6541f86ce4cd954)

lib/if.c

index 158303a3879fb9adc7e48728caf7ab4fd2ff2ec3..8d1b42cf805f7fc874da4513a0a19a9daad7270e 100644 (file)
--- a/lib/if.c
+++ b/lib/if.c
@@ -490,7 +490,8 @@ struct connected *if_lookup_address(const void *matchaddr, int family,
                addr.family = AF_INET6;
                addr.u.prefix6 = *((struct in6_addr *)matchaddr);
                addr.prefixlen = IPV6_MAX_BITLEN;
-       }
+       } else
+               assert(!"Attempted lookup of family not supported");
 
        match = NULL;