bgpd: Ignore aggregator attribute if it's malformed (0.0.0.0)

This is not the attribute involved in path selection and by rfc7606 it should
be just ignored.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
index 1ebba5f6b47d9fc43164007ae3b70384fc516048..d8566fed9f78e7f3a503f607b1b2a16ff8666a35 100644 (file)
--- a/bgpd/bgp_attr.c
+++ b/bgpd/bgp_attr.c
@@ -1669,13 +1669,10 @@ static int bgp_attr_aggregator(struct bgp_attr_parser_args *args)
        attr->flag |= ATTR_FLAG_BIT(BGP_ATTR_AGGREGATOR);
 
        /* Codification of AS 0 Processing */
-       if (aggregator_as == BGP_AS_ZERO) {
+       if (aggregator_as == BGP_AS_ZERO)
                flog_err(EC_BGP_ATTR_LEN,
                         "AGGREGATOR AS number is 0 for aspath: %s",
                         aspath_print(attr->aspath));
-               return bgp_attr_malformed(args, BGP_NOTIFY_UPDATE_MAL_AS_PATH,
-                                         args->total);
-       }
 
        return BGP_ATTR_PARSE_PROCEED;
 }
@@ -1705,13 +1702,10 @@ bgp_attr_as4_aggregator(struct bgp_attr_parser_args *args,
        attr->flag |= ATTR_FLAG_BIT(BGP_ATTR_AS4_AGGREGATOR);
 
        /* Codification of AS 0 Processing */
-       if (aggregator_as == BGP_AS_ZERO) {
+       if (aggregator_as == BGP_AS_ZERO)
                flog_err(EC_BGP_ATTR_LEN,
                         "AS4_AGGREGATOR AS number is 0 for aspath: %s",
                         aspath_print(attr->aspath));
-               return bgp_attr_malformed(args, BGP_NOTIFY_UPDATE_MAL_AS_PATH,
-                                         0);
-       }
 
        return BGP_ATTR_PARSE_PROCEED;
 }