]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: Initialise prd despite if it's safi-related or not
authorDonatas Abraitis <donatas@opensourcerouting.org>
Wed, 20 Sep 2023 12:05:35 +0000 (15:05 +0300)
committerDonatas Abraitis <donatas@opensourcerouting.org>
Wed, 20 Sep 2023 12:05:35 +0000 (15:05 +0300)
Fixes: d33bd631262d60a7c0a2d56a2fe143bff45e32f0 ("bgpd: fix coverity issue in bgpd")
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
bgpd/bgp_route.c

index 1e4334ed5f433edbf7cdbd0472aae77125126b54..5d98ec9428d5d1d6132bf1a6b3315d1dfb8bea99 100644 (file)
@@ -6597,7 +6597,7 @@ int bgp_static_set(struct vty *vty, bool negate, const char *ip_str,
        int ret;
        struct prefix p;
        struct bgp_static *bgp_static;
-       struct prefix_rd prd;
+       struct prefix_rd prd = {};
        struct bgp_dest *pdest;
        struct bgp_dest *dest;
        struct bgp_table *table;
@@ -6626,7 +6626,6 @@ int bgp_static_set(struct vty *vty, bool negate, const char *ip_str,
        }
 
        if (safi == SAFI_MPLS_VPN || safi == SAFI_EVPN) {
-               memset(&prd, 0, sizeof(prd));
                ret = str2prefix_rd(rd_str, &prd);
                if (!ret) {
                        vty_out(vty, "%% Malformed rd\n");