zebra: warn if advertising connected with _REAL unset

The implementation in zebra and the zclient protocol allow to communicate
addresses to clients which are not yet in the kernel.

This is usually not done and most clients seem to expect an address to be
configured in the kernel when they receive it. Therefore, it seems
reasonable to issue a warning when advertising an address to the clients
that is not yet in the kernel.

Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

diff --git a/zebra/redistribute.c b/zebra/redistribute.c
index 47658248565323d51400a4fc77be608230c21d58..078c2ad0b36ec5ed44d7a94bb8047670e9dc3b6b 100644 (file)
--- a/zebra/redistribute.c
+++ b/zebra/redistribute.c
@@ -358,6 +358,9 @@ zebra_interface_address_add_update (struct interface *ifp,
                  p->prefixlen, ifc->ifp->name);
     }
 
+  if (!CHECK_FLAG(ifc->conf, ZEBRA_IFC_REAL))
+    zlog_warn("WARNING: advertising address to clients that is not yet usable.");
+
   router_id_add_address(ifc);
 
   for (ALL_LIST_ELEMENTS (zebrad.client_list, node, nnode, client))