]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: listener thread pointer is already NULL
authorDonald Sharp <sharpd@nvidia.com>
Fri, 30 Apr 2021 18:10:31 +0000 (14:10 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Sun, 2 May 2021 11:31:30 +0000 (07:31 -0400)
FRR in thread.c clears the passed in double pointer when
we pull it off the ready queue and pass it back to
the calling function via thread_fetch().

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd/bgp_network.c

index 8d9024e07c512e7d1a0c3efe8615260806e7cc5f..55d7a29d9890481ab7f2e82331dba6bc5cf0d97d 100644 (file)
@@ -376,7 +376,6 @@ static int bgp_accept(struct thread *thread)
                             accept_sock);
                return -1;
        }
-       listener->thread = NULL;
 
        thread_add_read(bm->master, bgp_accept, listener, accept_sock,
                        &listener->thread);
@@ -838,7 +837,6 @@ static int bgp_listener(int sock, struct sockaddr *sa, socklen_t salen,
                listener->bgp = bgp;
 
        memcpy(&listener->su, sa, salen);
-       listener->thread = NULL;
        thread_add_read(bm->master, bgp_accept, listener, sock,
                        &listener->thread);
        listnode_add(bm->listen_sockets, listener);