]> git.puffer.fish Git - matthieu/frr.git/commitdiff
ospfd: Coverity warns that we could possibly use unininted data
authorDonald Sharp <sharpd@nvidia.com>
Wed, 27 Jul 2022 16:17:50 +0000 (12:17 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Wed, 27 Jul 2022 16:17:50 +0000 (12:17 -0400)
In ospf_handle_exnl_lsa_lsId_chg there is a code path
where that we may be using uninitialized data for decisions.
Doubtful that this happens but let's make it less likely to
even more.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
ospfd/ospf_lsa.c

index 2c2ddd4394d9fb007e122ce9a96a045232cf8a09..af05f5b59e9fa78c80eb20356a0c7b3e90aff13f 100644 (file)
@@ -1761,7 +1761,7 @@ static struct ospf_lsa *ospf_handle_exnl_lsa_lsId_chg(struct ospf *ospf,
        struct as_external_lsa *al;
        struct in_addr mask;
        struct ospf_lsa *new;
-       struct external_info ei_summary;
+       struct external_info ei_summary = {};
        struct external_info *ei_old;
 
        lsa = ospf_lsdb_lookup_by_id(ospf->lsdb, OSPF_AS_EXTERNAL_LSA,