]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: Add some color to why nexthop_set failed 13704/head
authorDonald Sharp <sharpd@nvidia.com>
Wed, 7 Jun 2023 14:09:27 +0000 (10:09 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Mon, 12 Jun 2023 13:22:51 +0000 (09:22 -0400)
We are seeing some frequent test failures with
setting the nexthop correctly.  At this point
in time, I have no idea what is going wrong,
but I don't have a bunch of information either,
so let's add the local and remote values.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd/bgp_network.c

index e235a61f590e0fbe9d4e751204942ff40272ab68..73fe00c7ab991bccd79e5d7d727e605efc94ccc1 100644 (file)
@@ -810,8 +810,9 @@ int bgp_getsockname(struct peer *peer)
                                   &peer->nexthop, peer)) {
                flog_err(
                        EC_BGP_NH_UPD,
-                       "%s: nexthop_set failed, resetting connection - intf %s",
-                       peer->host,
+                       "%s: nexthop_set failed, local: %pSUp remote: %pSUp update_if: %s resetting connection - intf %s",
+                       peer->host, peer->su_local, peer->su_remote,
+                       peer->update_if ? peer->update_if : "(None)",
                        peer->nexthop.ifp ? peer->nexthop.ifp->name
                                          : "(Unknown)");
                return -1;