]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: bgp_vrf has already been derefed in all paths 8801/head
authorDonald Sharp <sharpd@nvidia.com>
Sat, 5 Jun 2021 16:57:55 +0000 (12:57 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Sat, 5 Jun 2021 16:57:55 +0000 (12:57 -0400)
Coverity scan found this issue.  The bgp_vrf variable in
ensure_vrf_tovpn_sid() has already been derefed in all paths
at this point in time.  No need to check for it existing
at this point.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd/bgp_mplsvpn.c

index f99d672c8afff1de54c493b8547890dd1bd940c8..564424a082a3b8fa2395887b1a29cfbbb14ace9f 100644 (file)
@@ -583,7 +583,7 @@ void ensure_vrf_tovpn_sid(struct bgp *bgp_vpn, struct bgp *bgp_vrf, afi_t afi)
         * skip when bgp vpn instance ins't allocated
         * or srv6 locator chunk isn't allocated
         */
-       if (!bgp_vpn || !bgp_vpn->srv6_locator_chunks || !bgp_vrf)
+       if (!bgp_vpn || !bgp_vpn->srv6_locator_chunks)
                return;
 
        tovpn_sid_index = bgp_vrf->vpn_policy[afi].tovpn_sid_index;