]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: Coverity mistakenly believes we can fall through
authorDonald Sharp <sharpd@nvidia.com>
Fri, 21 Apr 2023 11:57:19 +0000 (07:57 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Fri, 21 Apr 2023 11:57:19 +0000 (07:57 -0400)
Coverity has incorrectly found that a switch statement
can be fallen through.  It is missing the fact that the
previous case statement has a return through every path
it can get too.  Let's just appease coverity

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd/bgp_mplsvpn_snmp.c

index 20fec6d77be648f0ae6835d03e83a2f8955d4661..0208a6f5a5493bef6254067f68c3f7174932d466 100644 (file)
@@ -1627,6 +1627,7 @@ static uint8_t *mplsL3vpnRteTable(struct variable *v, oid name[],
                        }
                } else
                        return SNMP_INTEGER(MPLSL3VPNVRFRTECIDRTYPEOTHER);
+               break;
        case MPLSL3VPNVRFRTEINETCIDRPROTO:
                switch (pi->type) {
                case ZEBRA_ROUTE_CONNECT: