bgpd: Validate all large communities if specified more per line

```
(config)# bgp large-community-list standard FRR-1 permit 1:1:1:1
% Malformed community-list value
(config)# bgp large-community-list standard FRR-1 permit 1:1:1 1:2
% Malformed community-list value
(config)# bgp large-community-list standard FRR-1 permit 1:1:1 1:2 3:3:2
% Malformed community-list value
(config)# bgp large-community-list standard FRR-1 permit 1:1:1 1:2 3:3:2 0:0:0
% Malformed community-list value
(config)# bgp large-community-list standard FRR-1 permit 0:0:1231321231414
% Malformed community-list value
(config)# bgp large-community-list standard FRR-1 permit 1:1:1 1:2:3 3:3:2 0:0:
% Malformed community-list value
(config)# bgp large-community-list standard FRR-1 permit 1:1:1 1:2:3 3:3:2 0:2:3
(config)# bgp large-community-list standard FRR-1 permit 1:1:1 1:2:3 3:3:2
(config)#
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

diff --git a/bgpd/bgp_clist.c b/bgpd/bgp_clist.c
index cf4d44ea22d8651cb72769118c29fe5358a7f1f1..1361ef99bea07fc294655afdc69e7e2260774610 100644 (file)
--- a/bgpd/bgp_clist.c
+++ b/bgpd/bgp_clist.c
@@ -1090,26 +1090,34 @@ struct lcommunity *lcommunity_list_match_delete(struct lcommunity *lcom,
 /* Helper to check if every octet do not exceed UINT_MAX */
 static bool lcommunity_list_valid(const char *community)
 {
-       int octets = 0;
-       char **splits;
-       int num;
+       int octets;
+       char **splits, **communities;
+       int num, num_communities;
 
-       frrstr_split(community, ":", &splits, &num);
+       frrstr_split(community, " ", &communities, &num_communities);
 
-       for (int i = 0; i < num; i++) {
-               if (strtoul(splits[i], NULL, 10) > UINT_MAX)
-                       return false;
+       for (int j = 0; j < num_communities; j++) {
+               octets = 0;
+               frrstr_split(communities[j], ":", &splits, &num);
+
+               for (int i = 0; i < num; i++) {
+                       if (strtoul(splits[i], NULL, 10) > UINT_MAX)
+                               return false;
 
-               if (strlen(splits[i]) == 0)
+                       if (strlen(splits[i]) == 0)
+                               return false;
+
+                       octets++;
+                       XFREE(MTYPE_TMP, splits[i]);
+               }
+               XFREE(MTYPE_TMP, splits);
+
+               if (octets < 3)
                        return false;
 
-               octets++;
-               XFREE(MTYPE_TMP, splits[i]);
+               XFREE(MTYPE_TMP, communities[j]);
        }
-       XFREE(MTYPE_TMP, splits);
-
-       if (octets < 3)
-               return false;
+       XFREE(MTYPE_TMP, communities);
 
        return true;
 }