bgpd: Show best path reason in JSON output for `show bgp` command

exit1-debian-9# show ip bgp json
{
 "vrfId": 0,
 "vrfName": "default",
 "tableVersion": 2,
 "routerId": "192.168.255.1",
 "defaultLocPrf": 100,
 "localAS": 65000,
 "routes": { "172.16.255.254/32": [
  {
    "valid":true,
    "bestpath":true,
    "selectionReason":"First path received",
    "pathFrom":"external",
    "prefix":"172.16.255.254",
    "prefixLen":32,
    "network":"172.16.255.254\/32",
    "metric":0,
    "weight":0,
    "peerId":"192.168.255.2",
    "path":"65001",
    "origin":"incomplete",
    "nexthops":[
      {
        "ip":"192.168.255.2",
        "hostname":"exit1-debian-9",
        "afi":"ipv4",
        "used":true
      }
    ]
  }
],"192.168.255.0/24": [
  {
    "valid":true,
    "bestpath":true,
    "selectionReason":"First path received",
    "pathFrom":"external",
    "prefix":"192.168.255.0",
    "prefixLen":24,
    "network":"192.168.255.0\/24",
    "metric":0,
    "weight":0,
    "peerId":"192.168.255.2",
    "path":"65001",
    "origin":"incomplete",
    "nexthops":[
      {
        "ip":"192.168.255.2",
        "hostname":"exit1-debian-9",
        "afi":"ipv4",
        "used":true
      }
    ]
  }
] }  }

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index db3eb95353d9b80586d7a1c0daad9f6875cddad0..a13d52b4c94e7cfc3a9ef96e5c6f185aa4a6a001 100644 (file)
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -8072,6 +8072,62 @@ enum bgp_display_type {
        normal_list,
 };
 
+static const char *
+bgp_path_selection_reason2str(enum bgp_path_selection_reason reason)
+{
+       switch (reason) {
+       case bgp_path_selection_none:
+               return "Nothing to Select";
+       case bgp_path_selection_first:
+               return "First path received";
+       case bgp_path_selection_evpn_sticky_mac:
+               return "EVPN Sticky Mac";
+       case bgp_path_selection_evpn_seq:
+               return "EVPN sequence number";
+       case bgp_path_selection_evpn_lower_ip:
+               return "EVPN lower IP";
+       case bgp_path_selection_evpn_local_path:
+               return "EVPN local ES path";
+       case bgp_path_selection_evpn_non_proxy:
+               return "EVPN non proxy";
+       case bgp_path_selection_weight:
+               return "Weight";
+       case bgp_path_selection_local_pref:
+               return "Local Pref";
+       case bgp_path_selection_local_route:
+               return "Local Route";
+       case bgp_path_selection_confed_as_path:
+               return "Confederation based AS Path";
+       case bgp_path_selection_as_path:
+               return "AS Path";
+       case bgp_path_selection_origin:
+               return "Origin";
+       case bgp_path_selection_med:
+               return "MED";
+       case bgp_path_selection_peer:
+               return "Peer Type";
+       case bgp_path_selection_confed:
+               return "Confed Peer Type";
+       case bgp_path_selection_igp_metric:
+               return "IGP Metric";
+       case bgp_path_selection_older:
+               return "Older Path";
+       case bgp_path_selection_router_id:
+               return "Router ID";
+       case bgp_path_selection_cluster_length:
+               return "Cluser length";
+       case bgp_path_selection_stale:
+               return "Path Staleness";
+       case bgp_path_selection_local_configured:
+               return "Locally configured route";
+       case bgp_path_selection_neighbor_ip:
+               return "Neighbor IP";
+       case bgp_path_selection_default:
+               return "Nothing left to compare";
+       }
+       return "Invalid (internal error)";
+}
+
 /* Print the short form route status for a bgp_path_info */
 static void route_vty_short_status_out(struct vty *vty,
                                       struct bgp_path_info *path,
@@ -8100,8 +8156,12 @@ static void route_vty_short_status_out(struct vty *vty,
                if (CHECK_FLAG(path->flags, BGP_PATH_DAMPED))
                        json_object_boolean_true_add(json_path, "damped");
 
-               if (CHECK_FLAG(path->flags, BGP_PATH_SELECTED))
+               if (CHECK_FLAG(path->flags, BGP_PATH_SELECTED)) {
                        json_object_boolean_true_add(json_path, "bestpath");
+                       json_object_string_add(json_path, "selectionReason",
+                                              bgp_path_selection_reason2str(
+                                                      path->net->reason));
+               }
 
                if (CHECK_FLAG(path->flags, BGP_PATH_MULTIPATH))
                        json_object_boolean_true_add(json_path, "multipath");
@@ -9254,62 +9314,6 @@ static void route_vty_out_tx_ids(struct vty *vty,
        }
 }
 
-static const char *bgp_path_selection_reason2str(
-       enum bgp_path_selection_reason reason)
-{
-       switch (reason) {
-       case bgp_path_selection_none:
-               return "Nothing to Select";
-       case bgp_path_selection_first:
-               return "First path received";
-       case bgp_path_selection_evpn_sticky_mac:
-               return "EVPN Sticky Mac";
-       case bgp_path_selection_evpn_seq:
-               return "EVPN sequence number";
-       case bgp_path_selection_evpn_lower_ip:
-               return "EVPN lower IP";
-       case bgp_path_selection_evpn_local_path:
-               return "EVPN local ES path";
-       case bgp_path_selection_evpn_non_proxy:
-               return "EVPN non proxy";
-       case bgp_path_selection_weight:
-               return "Weight";
-       case bgp_path_selection_local_pref:
-               return "Local Pref";
-       case bgp_path_selection_local_route:
-               return "Local Route";
-       case bgp_path_selection_confed_as_path:
-               return "Confederation based AS Path";
-       case bgp_path_selection_as_path:
-               return "AS Path";
-       case bgp_path_selection_origin:
-               return "Origin";
-       case bgp_path_selection_med:
-               return "MED";
-       case bgp_path_selection_peer:
-               return "Peer Type";
-       case bgp_path_selection_confed:
-               return "Confed Peer Type";
-       case bgp_path_selection_igp_metric:
-               return "IGP Metric";
-       case bgp_path_selection_older:
-               return "Older Path";
-       case bgp_path_selection_router_id:
-               return "Router ID";
-       case bgp_path_selection_cluster_length:
-               return "Cluser length";
-       case bgp_path_selection_stale:
-               return "Path Staleness";
-       case bgp_path_selection_local_configured:
-               return "Locally configured route";
-       case bgp_path_selection_neighbor_ip:
-               return "Neighbor IP";
-       case bgp_path_selection_default:
-               return "Nothing left to compare";
-       }
-       return "Invalid (internal error)";
-}
-
 static void route_vty_out_detail_es_info(struct vty *vty,
                                         struct bgp_path_info *pi,
                                         struct attr *attr,