]> git.puffer.fish Git - mirror/frr.git/commitdiff
ospf6d: fix integrated config
authorDinesh Dutt <ddutt@cumulusnetworks.com>
Mon, 26 Aug 2013 03:40:37 +0000 (03:40 +0000)
committerDavid Lamparter <equinox@opensourcerouting.org>
Wed, 20 Nov 2013 09:35:59 +0000 (10:35 +0100)
With integrated config, the line defining an interface to be p2p is defined
before assigning the interface to an area. When during the interface
transition, there is an attempt to generate a router LSA, the process
crashes. This fix addresses that.

Signed-off-by: Dinesh G Dutt <ddutt at cumulusnetworks.com>
Reviewed-by: Pradosh Mohapatra <pmohapat at cumulusnetworks.com>
Reviewed-by: Scott Feldman <sfeldma at cumulusnetworks.com>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
ospf6d/ospf6_interface.c

index fee1632a1a557e18702262c3a7174ee337727d3c..111b929a593d1eca14810835ee58139b95106e35 100644 (file)
@@ -654,6 +654,14 @@ interface_up (struct thread *thread)
       return 0;
     }
 
+  /* If no area assigned, return */
+  if (oi->area == NULL)
+    {
+      zlog_debug ("%s: Not scheduleing Hello for %s as there is no area assigned yet", __func__,
+                 oi->interface->name);
+      return 0;
+    }
+
   /* Join AllSPFRouters */
   ospf6_sso (oi->interface->ifindex, &allspfrouters6, IPV6_JOIN_GROUP);