bgpd: remove useless control checks about TCP connection

When attempting to get the src and destination addresses of a given
connection, the API may return the NULL pointer, but further code
in bgp_zebra_nexthop_set() already does a check about the given
pointer.

Relaxing the error code for all the returned adressing.

Fixes: 1ff9a340588a ("bgpd: bgpd-fsm-fix.patch")
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

diff --git a/bgpd/bgp_network.c b/bgpd/bgp_network.c
index dbb34b048fe698d22c84a548a171d2f8f8dd40d7..b409cbe706ecc4e4c1b94e57c42adead64317b06 100644 (file)
--- a/bgpd/bgp_network.c
+++ b/bgpd/bgp_network.c
@@ -875,11 +875,7 @@ int bgp_getsockname(struct peer *peer)
        }
 
        peer->su_local = sockunion_getsockname(peer->connection->fd);
-       if (!peer->su_local)
-               return -1;
        peer->su_remote = sockunion_getpeername(peer->connection->fd);
-       if (!peer->su_remote)
-               return -1;
 
        if (!bgp_zebra_nexthop_set(peer->su_local, peer->su_remote,
                                   &peer->nexthop, peer)) {