]> git.puffer.fish Git - mirror/frr.git/commitdiff
lib: Fix memory leak in snmp on shutdown 16555/head
authorDonald Sharp <sharpd@nvidia.com>
Fri, 9 Aug 2024 18:50:59 +0000 (14:50 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Mon, 12 Aug 2024 12:51:19 +0000 (08:51 -0400)
The events list is storing a `struct event *` allocated
as a MTYPE_TMP pointer, on shutdown ensure that it is
properly free'd up.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
lib/agentx.c

index 2e621d06a44dd25023bad1c41f09a815c7063ca2..2a3ff2355efbb417bbeb4237c8d5482753846d31 100644 (file)
@@ -377,9 +377,16 @@ void smux_events_update(void)
        agentx_events_update();
 }
 
+static void smux_events_delete_thread(void *arg)
+{
+       XFREE(MTYPE_TMP, arg);
+}
+
 void smux_terminate(void)
 {
-       if (events)
+       if (events) {
+               events->del = smux_events_delete_thread;
                list_delete(&events);
+       }
 }
 #endif /* SNMP_AGENTX */