pimd: Dereference before null check

In pim_ecmp_nexthop_search: All paths that lead to this null pointer comparison already dereference the pointer earlier
There may be a null pointer dereference, or else the comparison against null is unnecessary.

Coverity CID-1519749

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>

diff --git a/pimd/pim_nht.c b/pimd/pim_nht.c
index 9feb064e96f83d55ac0916784849db4505476843..f9a9aeb1b0673665a9a43dd1541bce735a7e5bec 100644 (file)
--- a/pimd/pim_nht.c
+++ b/pimd/pim_nht.c
@@ -495,12 +495,13 @@ static int pim_ecmp_nexthop_search(struct pim_instance *pim,
        uint32_t hash_val = 0, mod_val = 0;
        uint8_t nh_iter = 0, found = 0;
        uint32_t i, num_nbrs = 0;
-       pim_addr nh_addr = nexthop->mrib_nexthop_addr;
-       pim_addr grp_addr = pim_addr_from_prefix(grp);
 
        if (!pnc || !pnc->nexthop_num || !nexthop)
                return 0;
 
+       pim_addr nh_addr = nexthop->mrib_nexthop_addr;
+       pim_addr grp_addr = pim_addr_from_prefix(grp);
+
        memset(&nbrs, 0, sizeof(nbrs));
        memset(&ifps, 0, sizeof(ifps));