]> git.puffer.fish Git - mirror/frr.git/commitdiff
lib: CID 1399296: Assign instead of compare (PW.ASSIGN_WHERE_COMPARE_MEANT)
authorMartin Winter <mwinter@opensourcerouting.org>
Fri, 3 Feb 2017 11:37:48 +0000 (18:37 +0700)
committerMartin Winter <mwinter@opensourcerouting.org>
Fri, 10 Feb 2017 09:52:54 +0000 (16:52 +0700)
Needs to be a comparison, not assignment

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
lib/thread.c

index 5b8778b7178889d12a6364222166b39e3a7ac128..e10d0c48bfdc947b050d5ca61f0470406e37412c 100644 (file)
@@ -828,7 +828,7 @@ funcname_thread_add_read_write (int dir, struct thread_master *m,
 #else
   if (FD_ISSET (fd, fdset))
     {
-      zlog (NULL, LOG_WARNING, "There is already %s fd [%d]", (dir = THREAD_READ) ? "read" : "write", fd);
+      zlog (NULL, LOG_WARNING, "There is already %s fd [%d]", (dir == THREAD_READ) ? "read" : "write", fd);
       return NULL;
     }