]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: Print errors as error not as information when parsing OPEN message
authorDonatas Abraitis <donatas@opensourcerouting.org>
Sun, 1 Sep 2024 19:42:54 +0000 (22:42 +0300)
committerDonatas Abraitis <donatas@opensourcerouting.org>
Sun, 1 Sep 2024 19:42:54 +0000 (22:42 +0300)
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
bgpd/bgp_open.c

index 945076709c5c5bd8e6e316f5578eb95cb0a03ec0..6451c7cf3897e5b5555f37718706c23f473e1005 100644 (file)
@@ -1374,7 +1374,7 @@ int bgp_open_option_parse(struct peer *peer, uint16_t length,
                 * Check that we can read the opt_type and fetch it
                 */
                if (STREAM_READABLE(s) < 1) {
-                       zlog_info("%s Option length error", peer->host);
+                       zlog_err("%s Option length error", peer->host);
                        bgp_notify_send(peer->connection, BGP_NOTIFY_OPEN_ERR,
                                        BGP_NOTIFY_OPEN_MALFORMED_ATTR);
                        return -1;
@@ -1387,7 +1387,7 @@ int bgp_open_option_parse(struct peer *peer, uint16_t length,
                 */
                if (BGP_OPEN_EXT_OPT_PARAMS_CAPABLE(peer)) {
                        if (STREAM_READABLE(s) < 2) {
-                               zlog_info("%s Option length error", peer->host);
+                               zlog_err("%s Option length error", peer->host);
                                bgp_notify_send(peer->connection,
                                                BGP_NOTIFY_OPEN_ERR,
                                                BGP_NOTIFY_OPEN_MALFORMED_ATTR);
@@ -1397,7 +1397,7 @@ int bgp_open_option_parse(struct peer *peer, uint16_t length,
                        opt_length = stream_getw(s);
                } else {
                        if (STREAM_READABLE(s) < 1) {
-                               zlog_info("%s Option length error", peer->host);
+                               zlog_err("%s Option length error", peer->host);
                                bgp_notify_send(peer->connection,
                                                BGP_NOTIFY_OPEN_ERR,
                                                BGP_NOTIFY_OPEN_MALFORMED_ATTR);
@@ -1409,8 +1409,8 @@ int bgp_open_option_parse(struct peer *peer, uint16_t length,
 
                /* Option length check. */
                if (STREAM_READABLE(s) < opt_length) {
-                       zlog_info("%s Option length error (%d)", peer->host,
-                                 opt_length);
+                       zlog_err("%s Option length error (%d)", peer->host,
+                                opt_length);
                        bgp_notify_send(peer->connection, BGP_NOTIFY_OPEN_ERR,
                                        BGP_NOTIFY_OPEN_MALFORMED_ATTR);
                        return -1;