]> git.puffer.fish Git - matthieu/frr.git/commitdiff
pimd: Prevent uninited usage of nexthop
authorDonald Sharp <sharpd@nvidia.com>
Fri, 17 Sep 2021 09:41:37 +0000 (05:41 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Tue, 21 Sep 2021 11:54:54 +0000 (07:54 -0400)
pim_msdp_peer_rpf_check creates an nexthop to do
a rpf search against and doesn't initialize it
sucht that the pim_nexthop_lookup function is
making decisions against the nexthop just
created that was uninitialized.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
pimd/pim_msdp.c

index da8916ddbf734100b86cd9a52ec5d204664a7718..ddba33ff9d53768dad316646be4f0b1cd31e50f0 100644 (file)
@@ -720,7 +720,7 @@ static int pim_msdp_sa_comp(const void *p1, const void *p2)
 /* XXX: this can use a bit of refining and extensions */
 bool pim_msdp_peer_rpf_check(struct pim_msdp_peer *mp, struct in_addr rp)
 {
-       struct pim_nexthop nexthop;
+       struct pim_nexthop nexthop = {0};
 
        if (mp->peer.s_addr == rp.s_addr) {
                return true;