bgpd: fix a memleak on "set community none"

Signed-off-by: Christian Franke <chris@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

diff --git a/bgpd/bgp_routemap.c b/bgpd/bgp_routemap.c
index f2204003299874ba56155e1d94045b3f01334849..40f207653428b494e47b97d2ebcb446254ca859c 100644 (file)
--- a/bgpd/bgp_routemap.c
+++ b/bgpd/bgp_routemap.c
@@ -1347,6 +1347,9 @@ route_set_community (void *rule, struct prefix *prefix,
        {
          attr->flag &= ~(ATTR_FLAG_BIT (BGP_ATTR_COMMUNITIES));
          attr->community = NULL;
+         /* See the longer comment down below. */
+         if (old && old->refcnt == 0)
+           community_free(old);
          return RMAP_OKAY;
        }