]> git.puffer.fish Git - matthieu/frr.git/commitdiff
isisd: Do not explicitly set the thread pointer to NULL
authorDonatas Abraitis <donatas.abraitis@gmail.com>
Thu, 7 Oct 2021 10:20:15 +0000 (13:20 +0300)
committerDonatas Abraitis <donatas.abraitis@gmail.com>
Fri, 8 Oct 2021 05:56:42 +0000 (08:56 +0300)
FRR should only ever use the appropriate THREAD_ON/THREAD_OFF
semantics.  This is espacially true for the functions we
end up calling the thread for.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
isisd/fabricd.c
isisd/isis_spf.c

index 0f10a1516a1528afa4763ef2b8b3f6d8f42d90cd..2937df992c65ba2f860a17ebf0e71c70d10e9e68 100644 (file)
@@ -258,7 +258,6 @@ static int fabricd_initial_sync_timeout(struct thread *thread)
                  f->initial_sync_circuit->interface->name);
        f->initial_sync_state = FABRICD_SYNC_PENDING;
        f->initial_sync_circuit = NULL;
-       f->initial_sync_timeout = NULL;
        return 0;
 }
 
@@ -403,7 +402,6 @@ static uint8_t fabricd_calculate_fabric_tier(struct isis_area *area)
 static int fabricd_tier_set_timer(struct thread *thread)
 {
        struct fabricd *f = THREAD_ARG(thread);
-       f->tier_set_timer = NULL;
 
        fabricd_set_tier(f, f->tier_pending);
        return 0;
index 45e89897ffa43a1d47e5dcd808816a8be3f1f0d1..5718b48b9d42c23d4d9d6ebd1f10c808e28823c8 100644 (file)
@@ -1840,7 +1840,6 @@ static int isis_run_spf_cb(struct thread *thread)
        int have_run = 0;
 
        XFREE(MTYPE_ISIS_SPF_RUN, run);
-       area->spf_timer[level - 1] = NULL;
 
        if (!(area->is_type & level)) {
                if (IS_DEBUG_SPF_EVENTS)