]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: Return bool type for ecommunity_add_val and subgroup_announce_check
authorDonatas Abraitis <donatas.abraitis@gmail.com>
Thu, 2 Jul 2020 08:08:29 +0000 (11:08 +0300)
committerDonatas Abraitis <donatas.abraitis@gmail.com>
Sun, 5 Jul 2020 19:08:01 +0000 (22:08 +0300)
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd/bgp_ecommunity.c
bgpd/bgp_route.c

index d13da74b047ae383e5a41b0508a68de0061ceb8b..7d5cac4d62f2a87f5f23f212b43fafdd9f3ee7cf 100644 (file)
@@ -107,14 +107,14 @@ bool ecommunity_add_val(struct ecommunity *ecom, struct ecommunity_val *eval,
                            p[1] == eval->val[1]) {
                                if (overwrite) {
                                        memcpy(p, eval->val, ECOMMUNITY_SIZE);
-                                       return 1;
+                                       return true;
                                }
-                               return 0;
+                               return false;
                        }
                }
                int ret = memcmp(p, eval->val, ECOMMUNITY_SIZE);
                if (ret == 0)
-                       return 0;
+                       return false;
                if (ret > 0) {
                        if (!unique)
                                break;
index 6ae7a59a14d52ba415c784f42a212f5315da0871..7bfefde482b63f220e2852667ce5056d44240cc5 100644 (file)
@@ -1941,7 +1941,7 @@ bool subgroup_announce_check(struct bgp_node *rn, struct bgp_path_info *pi,
 
        /* Codification of AS 0 Processing */
        if (aspath_check_as_zero(attr->aspath))
-               return 0;
+               return false;
 
        if (CHECK_FLAG(bgp->flags, BGP_FLAG_GRACEFUL_SHUTDOWN)) {
                if (peer->sort == BGP_PEER_IBGP