isisd: Fix read past end of string

using a memcpy for a strdup'ed string.  bad mojo

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

diff --git a/isisd/isis_te.c b/isisd/isis_te.c
index 1a1e0dc294d9ee2eba7b84148cc91f61b52894ee..924922339c13128dedc17d2ca88ca296f3f3ac58 100644 (file)
--- a/isisd/isis_te.c
+++ b/isisd/isis_te.c
@@ -439,7 +439,7 @@ static struct ls_vertex *lsp_to_vertex(struct ls_ted *ted, struct isis_lsp *lsp)
                        SET_FLAG(lnode.flags, LS_NODE_ROUTER_ID6);
                }
                if (tlvs->hostname) {
-                       memcpy(&lnode.name, tlvs->hostname, MAX_NAME_LENGTH);
+                       strlcpy(lnode.name, tlvs->hostname, MAX_NAME_LENGTH);
                        SET_FLAG(lnode.flags, LS_NODE_NAME);
                }
                if (tlvs->router_cap) {