lib: uninitialized variable (2) (Coverity 1469898)

Previous correction (2c2d5cb397c140c05ad81e8c79273bd3af13b595) was not enough,
so now it is ensured that the argument shift is not negative nor zero.

Signed-off-by: F. Aragon <paco@voltanet.io>

diff --git a/lib/command.c b/lib/command.c
index a8e61c6bb4f1a8784ea2a441be104b1760c6deb9..0f38cdb83fad40ebafd4821b7915089bd63cfa5e 100644 (file)
--- a/lib/command.c
+++ b/lib/command.c
@@ -261,8 +261,11 @@ void print_version(const char *progname)
 
 char *argv_concat(struct cmd_token **argv, int argc, int shift)
 {
-       int cnt = argc - shift;
-       const char *argstr[cnt];
+       int cnt = MAX(argc - shift, 0);
+       const char *argstr[cnt + 1];
+
+       if (!cnt)
+               return NULL;
 
        for (int i = 0; i < cnt; i++)
                argstr[i] = argv[i + shift]->arg;