]> git.puffer.fish Git - mirror/frr.git/commitdiff
zebra: Fix off by one error in no vni command
authorDonald Sharp <sharpd@cumulusnetworks.com>
Thu, 6 Aug 2020 12:29:34 +0000 (08:29 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Thu, 6 Aug 2020 20:31:06 +0000 (16:31 -0400)
Commit: e2bcfa3946aadc62af53cf53ff8d2f9fe7e5bab1

Introduced a off by one error in the `no vni XXX` command:
@@ -2337,12 +2336,10 @@ DEFUN (no_vrf_vni_mapping,
        "VNI-ID\n"
        "prefix-routes-only\n")
 {
-       int ret = 0;
        int filter = 0;
-       char err[ERR_STR_SZ];
-       vni_t vni = strtoul(argv[2]->arg, NULL, 10);

        ZEBRA_DECLVAR_CONTEXT(vrf, zvrf);
+       vni_t vni = strtoul(argv[1]->arg, NULL, 10);

        assert(vrf);
        assert(zvrf);

Fix it.

Fixes: #6867
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
zebra/zebra_vty.c

index 2ea04eee2e29ed5a40443821146fbe460494f8db..6390b30f5a452be925950f8c7b838ab0b2415d0f 100644 (file)
@@ -2434,7 +2434,7 @@ DEFUN (no_vrf_vni_mapping,
        int filter = 0;
 
        ZEBRA_DECLVAR_CONTEXT(vrf, zvrf);
-       vni_t vni = strtoul(argv[1]->arg, NULL, 10);
+       vni_t vni = strtoul(argv[2]->arg, NULL, 10);
 
        assert(vrf);
        assert(zvrf);