bgpd: fix memory leak in rpki_create_socket

Fix memory leak in rpki_create_socket. Coverity scanner issue 1575914.

Fixes: a951752 ("bgpd: create cache server socket in vrf")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

diff --git a/bgpd/bgp_rpki.c b/bgpd/bgp_rpki.c
index 2c716a0e28ba6362128ff0a4a8d49a09887eb418..65f4f1e08975f7472d0f88794f740faefc476535 100644 (file)
--- a/bgpd/bgp_rpki.c
+++ b/bgpd/bgp_rpki.c
@@ -1343,8 +1343,10 @@ static int rpki_create_socket(void *_cache)
                socket = vrf_socket(res->ai_family, res->ai_socktype,
                                    res->ai_protocol, vrf->vrf_id, NULL);
        }
-       if (socket < 0)
+       if (socket < 0) {
+               freeaddrinfo(res);
                return -1;
+       }
 
        pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, &cancel_state);
        timeout.tv_sec = 30;