]> git.puffer.fish Git - matthieu/frr.git/commitdiff
ospfd: fix memleak from fuzzing modifications
authorQuentin Young <qlyoung@cumulusnetworks.com>
Fri, 20 Mar 2020 21:31:35 +0000 (17:31 -0400)
committerQuentin Young <qlyoung@nvidia.com>
Mon, 15 Nov 2021 22:12:33 +0000 (17:12 -0500)
skipping a flood results in refcnt not being decremented and in the long
run a memleak, unfortunately we gotta do this one

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
ospfd/ospf_packet.c

index 707aae438cd9162feabc7a64a6f05b120f7564b8..c99f03f6650aca476649713193fa167fd5da0fc5 100644 (file)
@@ -2130,12 +2130,10 @@ static void ospf_ls_upd(struct ospf *ospf, struct ip *iph,
                                DISCARD_LSA(lsa, 4);
                        }
 
-#ifndef FUZZING
                        /* Actual flooding procedure. */
                        if (ospf_flood(oi->ospf, nbr, current, lsa)
                            < 0) /* Trap NSSA later. */
                                DISCARD_LSA(lsa, 5);
-#endif
                        continue;
                }