]> git.puffer.fish Git - mirror/frr.git/commitdiff
lib: remove incorrect comment from northbound 14631/head
authorIgor Ryzhov <iryzhov@nfware.com>
Sat, 21 Oct 2023 09:56:49 +0000 (12:56 +0300)
committerIgor Ryzhov <iryzhov@nfware.com>
Sat, 21 Oct 2023 10:09:00 +0000 (13:09 +0300)
This was true when we had only a CLI for configuration. Now mgmtd has a
public frontend interface that can be used by external applications, and
they can send invalid requests that lead to errors.

This is still true for CLI though, so the same comment still stays in
`nb_cli_apply_changes_internal`.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
lib/northbound.c

index 69b96d36569307cc5d5e4609eafd062aa3936cfd..be49d92841ab7e500cb96c8dfebb99133b6276b4 100644 (file)
@@ -906,11 +906,6 @@ void nb_candidate_edit_config_changes(
        if (error && *error) {
                char buf[BUFSIZ];
 
-               /*
-                * Failure to edit the candidate configuration should never
-                * happen in practice, unless there's a bug in the code. When
-                * that happens, log the error but otherwise ignore it.
-                */
                snprintf(err_buf, err_bufsize,
                         "%% Failed to edit configuration.\n\n%s",
                         yang_print_errors(ly_native_ctx, buf, sizeof(buf)));