bgpd: fix crash in displaying json orf prefix-list

bgpd crashes when there is several entries in the prefix-list. No
backtrace is provided because the issue was catched from a code review.

Fixes: 856ca177c4 ("Added json formating support to show-...-neighbors-... bgp commands.")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
(cherry picked from commit 8ccf60921b85893d301186a0f8156fb702da379f)

diff --git a/lib/plist.c b/lib/plist.c
index 3e47428940a4c0175ddf9a4c0b7f20cfd7ee97a0..2f6b0cf959a5abf17d29713855da821dcb65c502 100644 (file)
--- a/lib/plist.c
+++ b/lib/plist.c
@@ -1504,7 +1504,6 @@ int prefix_bgp_show_prefix_list(struct vty *vty, afi_t afi, char *name,
        if (use_json) {
                json = json_object_new_object();
                json_prefix = json_object_new_object();
-               json_list = json_object_new_object();
 
                json_object_int_add(json_prefix, "prefixListCounter",
                                    plist->count);
@@ -1512,6 +1511,8 @@ int prefix_bgp_show_prefix_list(struct vty *vty, afi_t afi, char *name,
                                       plist->name);
 
                for (pentry = plist->head; pentry; pentry = pentry->next) {
+                       json_list = json_object_new_object();
+
                        json_object_int_add(json_list, "seq", pentry->seq);
                        json_object_string_add(json_list, "seqPrefixListType",
                                               prefix_list_type_str(pentry));