pimd: Fixing coverity issues

Signed-off-by: Sai Gomathi <nsaigomathi@vmware.com>

diff --git a/pimd/pim_main.c b/pimd/pim_main.c
index 96132c44256d214eebc93f65482a78e34f37d9c2..780595ca11fb979fb3e4344a43c2b79bec883855 100644 (file)
--- a/pimd/pim_main.c
+++ b/pimd/pim_main.c
@@ -115,7 +115,6 @@ int main(int argc, char **argv, char **envp)
                        break;
                default:
                        frr_help_exit(1);
-                       break;
                }
        }
 

diff --git a/pimd/pim_mroute.c b/pimd/pim_mroute.c
index ab6d8c17dfc5286d0a70439e568d4404f4022b0a..7743bcc51048dcb6ac2f3b28603ffc4d3abde990 100644 (file)
--- a/pimd/pim_mroute.c
+++ b/pimd/pim_mroute.c
@@ -668,19 +668,15 @@ static int pim_mroute_msg(struct pim_instance *pim, const char *buf,
                case IGMPMSG_WRONGVIF:
                        return pim_mroute_msg_wrongvif(pim->mroute_socket, ifp,
                                                       msg);
-                       break;
                case IGMPMSG_NOCACHE:
                        return pim_mroute_msg_nocache(pim->mroute_socket, ifp,
                                                      msg);
-                       break;
                case IGMPMSG_WHOLEPKT:
                        return pim_mroute_msg_wholepkt(pim->mroute_socket, ifp,
                                                       (const char *)msg);
-                       break;
                case IGMPMSG_WRVIFWHOLE:
                        return pim_mroute_msg_wrvifwhole(
                                pim->mroute_socket, ifp, (const char *)msg);
-                       break;
                default:
                        break;
                }

diff --git a/pimd/pim_pim.c b/pimd/pim_pim.c
index e7ac0d4e5b2f6bc5f6f1cf3c4b12e13884c6cebc..2c2aebc61f0301ca64544e0a4aba4062d89634f0 100644 (file)
--- a/pimd/pim_pim.c
+++ b/pimd/pim_pim.c
@@ -322,7 +322,6 @@ int pim_pim_packet(struct interface *ifp, uint8_t *buf, size_t len)
                }
                return -1;
        }
-       return -1;
 }
 
 static void pim_sock_read_on(struct interface *ifp);

diff --git a/pimd/pim_rpf.c b/pimd/pim_rpf.c
index 98944e8fed78696b2fe86abfc02cc03dc1d65a96..66c6df65ad43d8dae707439f683f7407a281e700 100644 (file)
--- a/pimd/pim_rpf.c
+++ b/pimd/pim_rpf.c
@@ -419,8 +419,6 @@ int pim_rpf_addr_is_inaddr_none(struct pim_rpf *rpf)
        default:
                return 0;
        }
-
-       return 0;
 }
 
 int pim_rpf_addr_is_inaddr_any(struct pim_rpf *rpf)
@@ -434,8 +432,6 @@ int pim_rpf_addr_is_inaddr_any(struct pim_rpf *rpf)
        default:
                return 0;
        }
-
-       return 0;
 }
 
 int pim_rpf_is_same(struct pim_rpf *rpf1, struct pim_rpf *rpf2)