]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: strncpy -> strlcpy
authorQuentin Young <qlyoung@cumulusnetworks.com>
Tue, 26 Feb 2019 19:50:06 +0000 (19:50 +0000)
committerQuentin Young <qlyoung@cumulusnetworks.com>
Tue, 26 Feb 2019 20:50:17 +0000 (20:50 +0000)
strncpy is a byte copy function not a string copy function

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
bgpd/rfapi/rfapi_import.c

index 6b37073e0e7b0744596a766e5000c6fa0ff3f167..df2d404f6987317c4c99b705b922e088778c3f08 100644 (file)
@@ -2190,7 +2190,7 @@ static void rfapiItBiIndexDump(struct agg_node *rn)
                        prefix2str(&k->extra->vnc.import.aux_prefix,
                                   buf_aux_pfx, sizeof(buf_aux_pfx));
                } else
-                       strncpy(buf_aux_pfx, "(none)", PREFIX_STRLEN);
+                       strlcpy(buf_aux_pfx, "(none)", sizeof(buf_aux_pfx));
 
                vnc_zlog_debug_verbose("bpi %p, peer %p, rd %s, aux_prefix %s",
                                       k, k->peer, buf, buf_aux_pfx);
@@ -2221,7 +2221,7 @@ static struct bgp_path_info *rfapiItBiIndexSearch(
                        prefix2str(aux_prefix, buf_aux_pfx,
                                   sizeof(buf_aux_pfx));
                } else
-                       strncpy(buf_aux_pfx, "(nil)", sizeof(buf_aux_pfx));
+                       strlcpy(buf_aux_pfx, "(nil)", sizeof(buf_aux_pfx));
 
                vnc_zlog_debug_verbose("%s want prd=%s, peer=%p, aux_prefix=%s",
                                       __func__,