]> git.puffer.fish Git - mirror/frr.git/commitdiff
ospf6d: Free up list memory
authorDonald Sharp <sharpd@nvidia.com>
Wed, 18 Nov 2020 16:42:50 +0000 (11:42 -0500)
committerIgor Ryzhov <iryzhov@nfware.com>
Fri, 27 Nov 2020 14:41:33 +0000 (17:41 +0300)
OSPFv3 snmp code creates a list but never deletes the actual
list.  Do so.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
ospf6d/ospf6_snmp.c

index 57cc05529685a53e60d2273c5de61d29dd4287ff..36712ebfd7b7889123e5ebff8df04fea72b9c397 100644 (file)
@@ -1253,8 +1253,6 @@ static uint8_t *ospfv3NbrEntry(struct variable *v, oid *name, size_t *length,
        } else {
                /* We build a sorted list of interfaces */
                ifslist = list_new();
-               if (!ifslist)
-                       return NULL;
                ifslist->cmp = (int (*)(void *, void *))if_icmp_func;
                FOR_ALL_INTERFACES (vrf, iif)
                        listnode_add_sort(ifslist, iif);
@@ -1282,6 +1280,7 @@ static uint8_t *ospfv3NbrEntry(struct variable *v, oid *name, size_t *length,
                }
 
                list_delete_all_node(ifslist);
+               list_delete(&ifslist);
        }
 
        if (!oi || !on)