]> git.puffer.fish Git - mirror/frr.git/commitdiff
ospf6d: fix unguarded GR debug message
authorRenato Westphal <renato@opensourcerouting.org>
Tue, 31 Aug 2021 03:48:38 +0000 (00:48 -0300)
committerRenato Westphal <renato@opensourcerouting.org>
Tue, 31 Aug 2021 04:45:50 +0000 (01:45 -0300)
The message about ignoring a one-way hello should only be logged
when the router is acting a helper for another one.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
ospf6d/ospf6_message.c

index cd73e3d4062632c7cd83c42606e1a196a16024cf..3dcc74589adddffa32859352127857dc3d228bca 100644 (file)
@@ -515,12 +515,12 @@ static void ospf6_hello_recv(struct in6_addr *src, struct in6_addr *dst,
        if (twoway)
                thread_execute(master, twoway_received, on, 0);
        else {
-               if (IS_DEBUG_OSPF6_GR)
-                       zlog_debug(
-                               "%s, Received oneway hello from RESTARTER so ignore here.",
-                               __PRETTY_FUNCTION__);
-
-               if (!OSPF6_GR_IS_ACTIVE_HELPER(on)) {
+               if (OSPF6_GR_IS_ACTIVE_HELPER(on)) {
+                       if (IS_DEBUG_OSPF6_GR)
+                               zlog_debug(
+                                       "%s, Received oneway hello from RESTARTER so ignore here.",
+                                       __PRETTY_FUNCTION__);
+               } else {
                        /* If the router is DR_OTHER, RESTARTER will not wait
                         * until it receives the hello from it if it receives
                         * from DR and BDR.