]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: agg_node_lookup not unlocking
authorDonald Sharp <sharpd@cumulusnetworks.com>
Mon, 24 Feb 2020 13:45:36 +0000 (08:45 -0500)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Thu, 27 Feb 2020 14:41:58 +0000 (09:41 -0500)
SA has found a case where we did a table lookup of a rn( and
associated lock of that node ) where we did not unlock it.

Unlock the node before moving on to the next one.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd/rfapi/rfapi_rib.c

index 39d4b3ee298fd2811d56cf6d449d4b2d7ad6a10a..b7ec35c661fadfd44554ffb3eb37f61308523cb2 100644 (file)
@@ -2184,6 +2184,7 @@ void rfapiRibPendingDeleteRoute(struct bgp *bgp, struct rfapi_import_table *it,
                                rfapiRibUpdatePendingNode(
                                        bgp, m->rfd, it, it_node,
                                        m->rfd->response_lifetime);
+                               agg_unlock_node(rn);
                        }
                }