tests: Adopt tests for AS4 handling

When received malformed AS4 capability, it should return -1 (notification send),
and the received flag SHOULD NOT be set.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

diff --git a/tests/bgpd/test_aspath.c b/tests/bgpd/test_aspath.c
index 799733b7b53c3e3b8c08fbca0d2a1b01a9a98110..29d2e4cf6e29a3f0c2f4e420baa068e0b58f7a7e 100644 (file)
--- a/tests/bgpd/test_aspath.c
+++ b/tests/bgpd/test_aspath.c
@@ -653,7 +653,7 @@ static struct aspath_tests {
                "8466 3 52737 4096",
                AS4_DATA,
                -1,
-               PEER_CAP_AS4_RCV,
+               0,
                {
                        COMMON_ATTRS,
                        BGP_ATTR_FLAG_TRANS | BGP_ATTR_FLAG_OPTIONAL,
@@ -685,7 +685,7 @@ static struct aspath_tests {
                "8466 3 52737 4096",
                AS4_DATA,
                -1,
-               PEER_CAP_AS4_RCV | PEER_CAP_AS4_ADV,
+               0,
                {
                        COMMON_ATTRS,
                        BGP_ATTR_FLAG_TRANS,
@@ -701,7 +701,7 @@ static struct aspath_tests {
                "8466 3 52737 4096",
                AS4_DATA,
                -1,
-               PEER_CAP_AS4_RCV | PEER_CAP_AS4_ADV,
+               0,
                {
                        COMMON_ATTRS,
                        BGP_ATTR_FLAG_TRANS,
@@ -717,7 +717,7 @@ static struct aspath_tests {
                "8466 3 52737 4096",
                AS4_DATA,
                -1,
-               PEER_CAP_AS4_RCV | PEER_CAP_AS4_ADV,
+               0,
                {
                        COMMON_ATTRS,
                        BGP_ATTR_FLAG_TRANS,
@@ -733,7 +733,7 @@ static struct aspath_tests {
                "8466 3 52737 4096",
                AS4_DATA,
                -1,
-               PEER_CAP_AS4_RCV | PEER_CAP_AS4_ADV,
+               0,
                {
                        COMMON_ATTRS,
                        BGP_ATTR_FLAG_TRANS | BGP_ATTR_FLAG_OPTIONAL,

diff --git a/tests/bgpd/test_capability.c b/tests/bgpd/test_capability.c
index 38f896b30ca8a12dee9fe8c17f96e52cb28d751c..1ee47a38e457333178c201ff983f87b6302f87bf 100644 (file)
--- a/tests/bgpd/test_capability.c
+++ b/tests/bgpd/test_capability.c
@@ -617,6 +617,7 @@ static struct test_segment misc_segments[] =
                        },
                        2,
                        SHOULD_ERR,
+                       -1,
                },
                {
                        "dyn-empty",