ospf6d: ospf6d is crashing upon receiving duplicated Grace LSA.

Description:
	When grace lsa received, DUT is adding
	the copy of the  lsas  to all nbrs retransmission  list as part of
	flooding procedure and subsequently incrementing the rmt counter in
	the original the LSA. This counter is supposed to be decremented
	when ack is received by nbr and the lsa  will be removed from retransmission list.

	But in our current scenario,
	Step-1:
		When GR helper is disabled, if DUT receives the grace lsa
		it adds the lsa copy to nbrs retransmission list but original
		LSA will be discarded since GR helper disabled.
	Step-2:
		GR helper enabled and DUT receives the grace lsa, as part
		of flooding process all nbrs have same copy of lsa in their
		corresponding rmt list which was added in step -1 due to this
		the corresponding rmt counter in the original lsa is not getting
		incremented.
	Step-3:
		If the same copy of the grace lsa received by DUT, It considers
		as implicit ack from nbr if the same copy of the lsa exits in its
		rmt list and subsequently  decrement the rmt counter.
	Since counter is zero (because of step-1 and 2) , it is asserting while decrement.

Signed-off-by: Rajesh Girada <rgirada@vmware.com>
(cherry picked from commit a60eab9e109fd2625dc3f941d7d9be2b6312f593)

diff --git a/ospf6d/ospf6_flood.c b/ospf6d/ospf6_flood.c
index 3a242575cd71477ee30ded2320023a2f56235369..ade008c4928a68d148dbd75beac485c188074a09 100644 (file)
--- a/ospf6d/ospf6_flood.c
+++ b/ospf6d/ospf6_flood.c
@@ -1027,15 +1027,8 @@ void ospf6_receive_lsa(struct ospf6_neighbor *from,
                if (old)
                        ospf6_flood_clear(old);
 
-               /* (b) immediately flood and (c) remove from all retrans-list */
-               /* Prevent self-originated LSA to be flooded. this is to make
-               reoriginated instance of the LSA not to be rejected by other
-               routers
-               due to MinLSArrival. */
                self_originated = (new->header->adv_router
                                   == from->ospf6_if->area->ospf6->router_id);
-               if (!self_originated)
-                       ospf6_flood(from, new);
 
                /* Received non-self-originated Grace LSA. */
                if (IS_GRACE_LSA(new) && !self_originated) {
@@ -1081,6 +1074,14 @@ void ospf6_receive_lsa(struct ospf6_neighbor *from,
                        }
                }
 
+               /* (b) immediately flood and (c) remove from all retrans-list */
+               /* Prevent self-originated LSA to be flooded. this is to make
+                * reoriginated instance of the LSA not to be rejected by other
+                * routers due to MinLSArrival.
+                */
+               if (!self_originated)
+                       ospf6_flood(from, new);
+
                /* (d), installing lsdb, which may cause routing
                        table calculation (replacing database copy) */
                ospf6_install_lsa(new);