]> git.puffer.fish Git - mirror/frr.git/commitdiff
zebra: Print out client who sent us bad data
authorDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 17 Jul 2019 00:24:26 +0000 (20:24 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 17 Jul 2019 00:31:22 +0000 (20:31 -0400)
A client was sending zebra a route with no nexthops!  Update the
error message to tell us *Which* daemon is doing this.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
zebra/zapi_msg.c

index 387c09be874aba5afcdceb80c05c32a2c2ecf5f8..b6a8ee950c3d94905e86a91fa7ae2a2ab1eef497 100644 (file)
@@ -1431,12 +1431,10 @@ static void zread_route_add(ZAPI_HANDLER_ARGS)
 
        if (!CHECK_FLAG(api.message, ZAPI_MESSAGE_NEXTHOP)
            || api.nexthop_num == 0) {
-               char buf_prefix[PREFIX_STRLEN];
-
-               prefix2str(&api.prefix, buf_prefix, sizeof(buf_prefix));
                flog_warn(EC_ZEBRA_RX_ROUTE_NO_NEXTHOPS,
-                         "%s: received a route without nexthops for prefix %s",
-                         __func__, buf_prefix);
+                         "%s: received a route without nexthops for prefix %pFX from client %s",
+                         __func__, &api.prefix,
+                         zebra_route_string(client->proto));
                XFREE(MTYPE_RE, re);
                return;
        }