]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: Do not call bgp_soft_reconfig_in() twice in a row on policy change 13137/head
authorDonatas Abraitis <donatas@opensourcerouting.org>
Wed, 29 Mar 2023 20:21:35 +0000 (23:21 +0300)
committerDonatas Abraitis <donatas@opensourcerouting.org>
Thu, 30 Mar 2023 06:33:24 +0000 (09:33 +0300)
Just realized it was a stupid copy/paste.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
bgpd/bgpd.c

index ed1e2593a0e8fca1f60d083629a9cb86f6377245..bd3e8c7b244aedb68fd4ef7b02ae89173219c57d 100644 (file)
@@ -5602,11 +5602,8 @@ void peer_on_policy_change(struct peer *peer, afi_t afi, safi_t safi,
                if (bgp_soft_reconfig_in(peer, afi, safi))
                        return;
 
-               if (CHECK_FLAG(peer->af_flags[afi][safi],
-                              PEER_FLAG_SOFT_RECONFIG))
-                       bgp_soft_reconfig_in(peer, afi, safi);
-               else if (CHECK_FLAG(peer->cap, PEER_CAP_REFRESH_OLD_RCV) ||
-                        CHECK_FLAG(peer->cap, PEER_CAP_REFRESH_NEW_RCV))
+               if (CHECK_FLAG(peer->cap, PEER_CAP_REFRESH_OLD_RCV) ||
+                   CHECK_FLAG(peer->cap, PEER_CAP_REFRESH_NEW_RCV))
                        bgp_route_refresh_send(peer, afi, safi, 0, 0, 0,
                                               BGP_ROUTE_REFRESH_NORMAL);
        }