]> git.puffer.fish Git - matthieu/frr.git/commitdiff
pimd: Remove impossible situation
authorDonald Sharp <sharpd@nvidia.com>
Thu, 16 Feb 2023 14:17:20 +0000 (09:17 -0500)
committerDonald Sharp <sharpd@nvidia.com>
Thu, 16 Feb 2023 14:17:20 +0000 (09:17 -0500)
Coverity complains that MLAG_MSG_NONE cannot be reached in
the switch statement.  Which is true so let's make it happy.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
pimd/pim_zpthread.c

index e12a5c4374f06bfad7e8d428e480aefb2403a675..b797ac184a75c2515dbd1950975faa42672c4e2b 100644 (file)
@@ -38,9 +38,6 @@ static void pim_mlag_zebra_fill_header(enum mlag_msg_type msg_type)
        uint16_t data_len = 0;
        uint16_t msg_cnt = 1;
 
-       if (msg_type == MLAG_MSG_NONE)
-               return;
-
        switch (msg_type) {
        case MLAG_REGISTER:
        case MLAG_DEREGISTER:
@@ -55,6 +52,7 @@ static void pim_mlag_zebra_fill_header(enum mlag_msg_type msg_type)
                fill_msg_type = MLAG_MROUTE_DEL_BULK;
                break;
        case MLAG_MSG_NONE:
+               return;
        case MLAG_STATUS_UPDATE:
        case MLAG_DUMP:
        case MLAG_MROUTE_ADD_BULK: