isisd: out of bounds access (Coverity 1473286)

rawlspid_print(), which uses a fixed-width 8-byte input, has been replaced with
a call to isis_format_id(), allowing giving the input size.

Signed-off-by: F. Aragon <paco@voltanet.io>

diff --git a/isisd/isis_spf.c b/isisd/isis_spf.c
index 6a7528623c08df603c5315f327f26d737373af95..42a019890fe0ee9d219114134e898e322e50d200 100644 (file)
--- a/isisd/isis_spf.c
+++ b/isisd/isis_spf.c
@@ -1068,7 +1068,8 @@ static void isis_spf_loop(struct isis_spftree *spftree,
                lsp = lsp_for_vertex(spftree, vertex);
                if (!lsp) {
                        zlog_warn("ISIS-Spf: No LSP found for %s",
-                                 rawlspid_print(vertex->N.id)); /* FIXME */
+                                 isis_format_id(vertex->N.id,
+                                                sizeof(vertex->N.id)));
                        continue;
                }