]> git.puffer.fish Git - mirror/frr.git/commitdiff
zebra: fix flaw in fix for import-table crash 2078/head
authorDon Slice <dslice@cumulusnetworks.com>
Tue, 17 Apr 2018 17:48:30 +0000 (10:48 -0700)
committerDon Slice <dslice@cumulusnetworks.com>
Tue, 17 Apr 2018 17:48:30 +0000 (10:48 -0700)
Realized (with coverity's help) the fix had a mistake by pasting in
the wrong route entry to unset the selected flag.  This fix takes
care of that mistake.

Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
zebra/redistribute.c

index 6a7a75f209b5cd897594c8bfff7f5a7086305664..2e19d6fb75c1cac47f004dcdc98d1994b44e10b1 100644 (file)
@@ -531,7 +531,7 @@ int zebra_add_import_table_entry(struct route_node *rn, struct route_entry *re,
                        re->tag, rmap_name);
 
        if (ret != RMAP_MATCH) {
-               UNSET_FLAG(same->flags, ZEBRA_FLAG_SELECTED);
+               UNSET_FLAG(re->flags, ZEBRA_FLAG_SELECTED);
                zebra_del_import_table_entry(rn, re);
                return 0;
        }