]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: All paths have already de-refed rd_str
authorDonald Sharp <sharpd@nvidia.com>
Fri, 21 Apr 2023 11:54:00 +0000 (07:54 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Fri, 21 Apr 2023 11:54:00 +0000 (07:54 -0400)
Coverity points out that rd_str has already been
deref'ed in all paths leading to this spot.  No
need to keep at it.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd/bgp_route.c

index 7809d9b0a9a27f869e588e77252431bfc62c5ed4..40ecdbb670dc9c9532787007324dbe7b7fc7d4fd 100644 (file)
@@ -7038,8 +7038,8 @@ int bgp_static_set_safi(afi_t afi, safi_t safi, struct vty *vty,
                bgp_static->label = label;
                bgp_static->prd = prd;
 
-               if (rd_str)
-                       bgp_static->prd_pretty = XSTRDUP(MTYPE_BGP, rd_str);
+               bgp_static->prd_pretty = XSTRDUP(MTYPE_BGP, rd_str);
+
                if (rmap_str) {
                        XFREE(MTYPE_ROUTE_MAP_NAME, bgp_static->rmap.name);
                        route_map_counter_decrement(bgp_static->rmap.map);