From: kamatchi soundaram <kamatchi@tdd.sj.nec.com>

Subject: [zebra 19259] Memory leak in OSPF

The detail of the memory leak follows:
 File name: ospf_interface.c
 Function name: ospf_if_new_hook().
 Type of leak: Overwriting the already allocated memory.
 Problem found and description:
 The ospf_new_if_params() fn allocates a memory for "auth_crypt" which
 is overwritten, down in the fn (ospf_if_new_hook) by explicitely allocating
 a memory for the same "auth_crypt".

 Fix: remove allocation from ospf_new_if_params()

diff --git a/ospfd/ospf_interface.c b/ospfd/ospf_interface.c
index a1b10c7439ccc0cc0e4b70e42538554180417386..9f566a452dffb29fa16f3eb3c6542b80742bcc91 100644 (file)
--- a/ospfd/ospf_interface.c
+++ b/ospfd/ospf_interface.c
@@ -490,8 +490,6 @@ ospf_new_if_params ()
   UNSET_IF_PARAM (oip, auth_crypt);
   UNSET_IF_PARAM (oip, auth_type);
   
-  oip->auth_crypt = list_new ();
-
   return oip;
 }