]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: Show TCP MSS per neighbor always, despite if it's configured or not
authorDonatas Abraitis <donatas@opensourcerouting.org>
Mon, 18 Sep 2023 12:54:43 +0000 (15:54 +0300)
committerDonatas Abraitis <donatas@opensourcerouting.org>
Mon, 18 Sep 2023 12:54:43 +0000 (15:54 +0300)
To show the TCP MSS value per neighbor you have to configure it, otherwise you
don't see the actual value.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
bgpd/bgp_vty.c

index e76968cdb0201e89f159ead3253f81db02956c94..9949ce8187247cfc294628f7f6414d35aed27cf7 100644 (file)
@@ -13693,13 +13693,10 @@ static void bgp_show_peer(struct vty *vty, struct peer *p, bool use_json,
                }
 
                /* Configured and Synced tcp-mss value for peer */
-               if (CHECK_FLAG(p->flags, PEER_FLAG_TCP_MSS)) {
-                       sync_tcp_mss = sockopt_tcp_mss_get(p->connection->fd);
-                       json_object_int_add(json_neigh, "bgpTcpMssConfigured",
-                                           p->tcp_mss);
-                       json_object_int_add(json_neigh, "bgpTcpMssSynced",
-                                           sync_tcp_mss);
-               }
+               sync_tcp_mss = sockopt_tcp_mss_get(p->connection->fd);
+               json_object_int_add(json_neigh, "bgpTcpMssConfigured",
+                                   p->tcp_mss);
+               json_object_int_add(json_neigh, "bgpTcpMssSynced", sync_tcp_mss);
 
                /* Extended Optional Parameters Length for BGP OPEN Message */
                if (BGP_OPEN_EXT_OPT_PARAMS_CAPABLE(p))
@@ -13779,11 +13776,9 @@ static void bgp_show_peer(struct vty *vty, struct peer *p, bool use_json,
                                p->delayopen);
 
                /* Configured and synced tcp-mss value for peer */
-               if (CHECK_FLAG(p->flags, PEER_FLAG_TCP_MSS)) {
-                       sync_tcp_mss = sockopt_tcp_mss_get(p->connection->fd);
-                       vty_out(vty, "  Configured tcp-mss is %d", p->tcp_mss);
-                       vty_out(vty, ", synced tcp-mss is %d\n", sync_tcp_mss);
-               }
+               sync_tcp_mss = sockopt_tcp_mss_get(p->connection->fd);
+               vty_out(vty, "  Configured tcp-mss is %d", p->tcp_mss);
+               vty_out(vty, ", synced tcp-mss is %d\n", sync_tcp_mss);
 
                /* Extended Optional Parameters Length for BGP OPEN Message */
                if (BGP_OPEN_EXT_OPT_PARAMS_CAPABLE(p))