]> git.puffer.fish Git - mirror/frr.git/commitdiff
ospf6d: Prevent heap-buffer-overflow with unknown type 16111/head
authorIggy Frankovic <iggy07@gmail.com>
Thu, 30 May 2024 11:59:54 +0000 (07:59 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Thu, 30 May 2024 12:02:25 +0000 (08:02 -0400)
When parsing a osf6 grace lsa field and we receive an
unknown tlv type, ospf6d was not incrementing the pointer
to get beyond the tlv.  Leaving a situation where ospf6d
would parse the packet incorrectly.

Signed-off-by: Iggy Frankovic <iggy07@gmail.com>
ospf6d/ospf6_gr_helper.c

index 229e0a4db8ab516c4f89dfd4616a2780a9f26524..f0e5d3a15c240183c3c6dd5dc880201bdf9c72fd 100644 (file)
@@ -176,6 +176,7 @@ static int ospf6_extract_grace_lsa_fields(struct ospf6_lsa *lsa,
                                return OSPF6_FAILURE;
                        break;
                default:
+                       sum += TLV_SIZE(tlvh);
                        if (IS_DEBUG_OSPF6_GR)
                                zlog_debug("%s, Ignoring unknown TLV type:%d",
                                           __func__, ntohs(tlvh->type));