lib: Release memory of YANG translation module on error

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
(cherry picked from commit b9941b3fec21eca413c4ca9460a264eb9afb7e34)

diff --git a/lib/yang_translator.c b/lib/yang_translator.c
index d562e4d29ea5085a7de68211171dcaeb97aa9e72..f3a355f88ce3c972ed71a2ecc96a7da12580874d 100644 (file)
--- a/lib/yang_translator.c
+++ b/lib/yang_translator.c
@@ -127,10 +127,15 @@ static void yang_mapping_add(struct yang_translator *translator, int dir,
        }
 }
 
+static void yang_tmodule_delete(struct yang_tmodule *tmodule)
+{
+       XFREE(MTYPE_YANG_TRANSLATOR_MODULE, tmodule);
+}
+
 struct yang_translator *yang_translator_load(const char *path)
 {
        struct yang_translator *translator;
-       struct yang_tmodule *tmodule;
+       struct yang_tmodule *tmodule = NULL;
        const char *family;
        struct lyd_node *dnode;
        struct ly_set *set;
@@ -282,15 +287,11 @@ struct yang_translator *yang_translator_load(const char *path)
 error:
        yang_dnode_free(dnode);
        yang_translator_unload(translator);
+       yang_tmodule_delete(tmodule);
 
        return NULL;
 }
 
-static void yang_tmodule_delete(struct yang_tmodule *tmodule)
-{
-       XFREE(MTYPE_YANG_TRANSLATOR_MODULE, tmodule);
-}
-
 void yang_translator_unload(struct yang_translator *translator)
 {
        for (size_t i = 0; i < YANG_TRANSLATE_MAX; i++)