bgpd: Configured suppress value cannot be less than the reuse value in bgp dampening

RFC 2439, Section 4.2; the values pair up for hysteresis.

Signed-off-by: Balaji.G <balajig81@gmail.com>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
(cherry picked from commit aa7dbb1067b7d02e1354fe1e5664ccb7d259d649)

diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index c8781a85b10e8bd02edabdeb9e62511bba0e2d99..6ca24af1584502250d31fd6d203efe67457fc352 100644 (file)
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -13530,6 +13530,14 @@ DEFUN (bgp_damp_set,
     }
 
   bgp = vty->index;
+
+  if (suppress < reuse)
+    {
+      vty_out (vty, "Suppress value cannot be less than reuse value %s",
+                    VTY_NEWLINE);
+      return 0;
+    }
+
   return bgp_damp_enable (bgp, bgp_node_afi (vty), bgp_node_safi (vty),
                          half, reuse, suppress, max);
 }