]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: Prevent Null pointer usage
authorDonald Sharp <sharpd@cumulusnetworks.com>
Mon, 27 Jul 2020 10:59:45 +0000 (06:59 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Mon, 27 Jul 2020 10:59:45 +0000 (06:59 -0400)
Coverity rightly points out that bgp_table_top might return
NULL and immediately deref'ing it might be a problem.
Add a bit of safety.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd/bgp_bmp.c

index db330f998c266a757aabec79e49637269f0746a8..af88547ca94aa2bc5a63a67ffe8be0e5df795181 100644 (file)
@@ -951,8 +951,11 @@ afibreak:
                /* initialize syncrdpos to the first
                 * mid-layer table entry
                 */
-               if (!bmp->syncrdpos)
+               if (!bmp->syncrdpos) {
                        bmp->syncrdpos = bgp_table_top(table);
+                       if (!bmp->syncrdpos)
+                               goto eor;
+               }
 
                /* look for a valid mid-layer table */
                do {