]> git.puffer.fish Git - mirror/frr.git/commitdiff
lib: remove nb/yang memory cleanup when daemonizing 16029/head
authorIgor Ryzhov <iryzhov@nfware.com>
Sun, 17 Mar 2024 20:44:28 +0000 (22:44 +0200)
committerMergify <37929162+mergify[bot]@users.noreply.github.com>
Fri, 17 May 2024 10:23:11 +0000 (10:23 +0000)
We're not calling any other termination functions to free allocated
memory when daemonizing except these two. There's no reason for such an
exception, and because of these calls we have the following libyang
warnings every time FRR is started:
```
MGMTD: libyang: String "15" not freed from the dictionary, refcount 2
MGMTD: libyang: String "200" not freed from the dictionary, refcount 2
MGMTD: libyang: String "mrib-then-urib" not freed from the dictionary, refcount 2
MGMTD: libyang: String "1000" not freed from the dictionary, refcount 2
MGMTD: libyang: String "10" not freed from the dictionary, refcount 2
MGMTD: libyang: String "5" not freed from the dictionary, refcount 2
```

Remove these calls to get rid of the unnecessary warnings.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
(cherry picked from commit a564710c34bdae8a0f0630f50b5718f0757d8edc)

lib/libfrr.c

index 9e472054dd5ae9b18c0e505c356b492f83b7c8a3..2861ebe0b93315018743734c536e7acf39998a89 100644 (file)
@@ -957,8 +957,6 @@ static void frr_daemonize(void)
        }
 
        close(fds[1]);
-       nb_terminate();
-       yang_terminate();
        frr_daemon_wait(fds[0]);
 }