]> git.puffer.fish Git - matthieu/frr.git/commitdiff
lib: close config files after reading (coverity)
authorChristian Hopps <chopps@labn.net>
Tue, 6 Jun 2023 18:27:04 +0000 (14:27 -0400)
committerMergify <37929162+mergify[bot]@users.noreply.github.com>
Wed, 7 Jun 2023 06:13:37 +0000 (06:13 +0000)
fixes coverity CID# 1564375

Signed-off-by: Christian Hopps <chopps@labn.net>
(cherry picked from commit f5626596ee5e052fc1116536704cd9c9ba5d7552)

lib/vty.c

index 50c4f80aae1e973bcb1fe39216545b811f64a871..fedbdbb81316124edad18731bb909fad581acd41 100644 (file)
--- a/lib/vty.c
+++ b/lib/vty.c
@@ -2217,6 +2217,8 @@ bool mgmt_vty_read_configs(void)
                line_num = 0;
                (void)config_from_file(vty, confp, &line_num);
                count++;
+
+               fclose(confp);
        }
 
        snprintf(path, sizeof(path), "%s/mgmtd.conf", frr_sysconfdir);
@@ -2240,6 +2242,8 @@ bool mgmt_vty_read_configs(void)
                line_num = 0;
                (void)config_from_file(vty, confp, &line_num);
                count++;
+
+               fclose(confp);
        }
 
        vty->pending_allowed = false;